Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iconlogger #16

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat: add iconlogger #16

merged 1 commit into from
Aug 15, 2023

Conversation

XDRAGON2002
Copy link
Contributor

Overview

This PR restores prettylogger to it's original state and instead adds a new logger iconlogger.

How to Test

Initialize the logger with icon or emoji.

Related issues/PRs:

Resolved #15

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

@XDRAGON2002
Copy link
Contributor Author

@dwertent I guess this is what you had in mind? Do let me know if there are any required changes, thanks!

iconlogger/colors.go Outdated Show resolved Hide resolved
prettylogger/logger.go Outdated Show resolved Hide resolved
prettylogger/logger.go Outdated Show resolved Hide resolved
prettylogger/logger.go Outdated Show resolved Hide resolved
iconlogger/colors.go Outdated Show resolved Hide resolved
Signed-off-by: DRAGON <anantvijay3@gmail.com>
@XDRAGON2002
Copy link
Contributor Author

@dwertent Have added the appropriate log statements as requested, and no the icon logger doesn't need to have colors, should have noticed that myself, have removed it now, thanks!

Copy link
Collaborator

@dwertent dwertent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@dwertent dwertent merged commit 60fa13b into kubescape:main Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new icon logger
3 participants