Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sensor): remove redundant warnings #52

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

alegrey91
Copy link
Collaborator

@alegrey91 alegrey91 commented Jul 5, 2023

Overview

This PR removes redundant logs during cni detection.

Checklist before requesting a review

put an [x] in the box to get it checked

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

3 similar comments
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@alegrey91 alegrey91 requested a review from dwertent July 5, 2023 08:52
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

e2e/controlplaneinfo_test.go Outdated Show resolved Hide resolved
e2e/controlplaneinfo_test.go Show resolved Hide resolved
sensor/CNI.go Show resolved Hide resolved
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@alegrey91 alegrey91 requested a review from dwertent July 5, 2023 11:30
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Summary:

  • License scan: success
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent
Copy link
Contributor

dwertent commented Jul 6, 2023

@alegrey91 I see many tests failed

@alegrey91
Copy link
Collaborator Author

@alegrey91 I see many tests failed

Yes, don't worry. It's related to the expired token for GH.
The important is that the tests with kind are working.
I'm going to provide a fix for this asap, but in the meantime we can merge it.

@dwertent dwertent merged commit ff7255f into master Jul 6, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants