remove git2go dependency #1001
Closed
remove git2go dependency #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I still need to edit README |
|
cc: @amirmalka |
|
Don't merge it as is, we have perf regression. |
fredbi
reviewed
Jan 6, 2023
| var allCommits []*git2go.Commit | ||
| err := logItr.Iterate(func(commit *git2go.Commit) bool { | ||
| var allCommits []*objectv5.Commit | ||
| err = logItr.ForEach(func(commit *objectv5.Commit) error { |
There was a problem hiding this comment.
@matthyx so if I understand correctly, this is the critical part that used to be slow (and might still be) and justified the use of the native git bindings? Is that correct?
There was a problem hiding this comment.
check the other comment
matthyx
commented
Jan 6, 2023
| prevTree, err = prevCommit.Tree() | ||
| if err != nil { | ||
| continue | ||
| } | ||
| } | ||
|
|
||
| diff, err := g.git2GoRepo.DiffTreeToTree(prevTree, tree, nil) | ||
| changes, err := prevTree.Diff(tree) |
There was a problem hiding this comment.
this is the slow part... merkle tree diffs are painfully slow
I have tried to walk around with some commit.Files() to skip the tree diffs, but it's still slow to open blobs in order to get files changed.
|
I assume this fixes #832. |
|
Will not be merged as explained here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove git2go dependency and replace functionalities with go-git.
Screenshots - If Any (Optional)
This PR fixes:
Checklist before requesting a review
Please open the PR against the
devbranch (Unless the PR contains only documentation changes)