fix(fix): mixed up change summary list

[HollowMan6]

Overview

Fix the mixed up change list (I don't know why you use pointers here, which is actually the culprit):

kubescape/core/pkg/fixhandler/fixhandler.go

Lines 296 to 305 in 875deb7

	for _, rulePaths := range rule.Paths {
	if rulePaths.FixPath.Path == "" {
	continue
	}
	if strings.HasPrefix(rulePaths.FixPath.Value, UserValuePrefix) && skipUserValues {
	continue
	}
	yamlExpression := fixPathToValidYamlExpression(rulePaths.FixPath.Path, rulePaths.FixPath.Value, documentIndex)
	rfi.YamlExpressions[yamlExpression] = &rulePaths.FixPath

rulePaths is a temporary variable, which will get released after use, it would of course be wrong if we store the address of that variable and try to use it after release.

kubescape scan test.yaml --format json --format-version v2 --output results
kubescape fix --no-confirm results.json

Issue before this fix

apiVersion: v1
kind: Pod
metadata:
  name: insert_to_mapping_node_1

spec:
  containers:
  - name: nginx_container
    image: nginx
# Proposed changes:
    securityContext:
      runAsNonRoot: true
      allowPrivilegeEscalation: false
      readOnlyRootFilesystem: true
  securityContext:
    runAsNonRoot: true
    allowPrivilegeEscalation: false

The 3rd one and 5th one are definitely wrong:

[info] The following changes will be applied:
File: test.yaml
Resource: insert_to_mapping_node_1
Kind: Pod
Changes:
	1) spec.containers[0].securityContext.allowPrivilegeEscalation = false
	2) spec.securityContext.allowPrivilegeEscalation = false
	3) spec.securityContext.allowPrivilegeEscalation = false
	4) spec.containers[0].securityContext.readOnlyRootFilesystem = true
	5) spec.containers[0].securityContext.allowPrivilegeEscalation = false

After fix

Now it works:

[info] The following changes will be applied:
File: test.yaml
Resource: insert_to_mapping_node_1
Kind: Pod
Changes:
	1) spec.containers[0].securityContext.readOnlyRootFilesystem = true
	2) spec.containers[0].securityContext.runAsNonRoot = true
	3) spec.containers[0].securityContext.allowPrivilegeEscalation = false
	4) spec.securityContext.runAsNonRoot = true
	5) spec.securityContext.allowPrivilegeEscalation = false

[dwertent]

Thank you :)