New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kubescape-windows-latest and fix CI #1236

Closed

HollowMan6 wants to merge 2 commits into kubescape:master from HollowMan6:master

Contributor

HollowMan6 commented May 16, 2023

Overview

I have triggered a release test in my fork:
https://github.com/HollowMan6/kubescape/actions/runs/4989131099

You can merge this once the workflow passed in my fork.


          Deprecate kubescape-windows-latest and fix CI

13ed740

Signed-off-by: Songlin Jiang <songlin.jiang@csc.fi>

HollowMan6 marked this pull request as ready for review

May 16, 2023 08:59

Contributor Author

HollowMan6 commented May 16, 2023

@dwertent Now ready

HollowMan6 marked this pull request as draft

May 16, 2023 10:04

Contributor Author

HollowMan6 commented May 16, 2023

Wait, looks like there's another issue: https://github.com/HollowMan6/kubescape/actions/runs/4989131099/jobs/8935817890


          Fix release artifacts

d956712

Signed-off-by: Songlin Jiang <songlin.jiang@csc.fi>

HollowMan6 marked this pull request as ready for review

May 16, 2023 12:59

Contributor Author

HollowMan6 commented May 16, 2023

Now I can confirm everything is good! https://github.com/HollowMan6/kubescape/actions/runs/4990876961

Contributor Author

HollowMan6 commented Aug 2, 2023

@craigbox @dwertent @matthyx Any plan to merge this PR?

HollowMan6 requested review from dwertent, matthyx and craigbox

August 2, 2023 12:40

Contributor

matthyx commented Oct 9, 2023

@HollowMan6 thanks, we won't merge this PR as we will soon revisit how we build and release kubescape, sorry for the late reply

matthyx closed this

Contributor Author

HollowMan6 commented Oct 9, 2023

@HollowMan6 thanks, we won't merge this PR as we will soon revisit how we build and release kubescape, sorry for the late reply

Okay, just a heads-up that you should not in any case remove/rename the kubescape.exe from the release asset as this is asked by the chocolatey community https://github.com/orgs/chocolatey-community/discussions/2186#discussioncomment-5440615 If you do have to make any changes related to this please discuss with them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment