Fix downloading arm64 binary for kubescape #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Songlin Jiang <songlin.jiang@csc.fi>
matthyx
approved these changes
May 17, 2023
|
Wait raspberry pi is aarch64 or arm64? I meant maybe the way you separate OS and arch creates more choices than what we have... |
|
Actually arm64 is the same as aarch64, just for the uname -m command in Linux it’s called aarch64 while in macOS it’s called arm64. |
|
I think we shall match aarch64 and arm64 at the same time, no matter what kind of OS it is, to make it more robust. Since these two names are for the same architecture. |
|
thanks for your update @HollowMan6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix #1237
Test:
curl -s https://raw.githubusercontent.com/HollowMan6/kubescape/macm1/install.sh | /bin/bashcc: @craigbox