Fix for Empty Build Number in cmd Version

[mohaidoss]

PR Type:

Bug fix

---

PR Description:

This PR includes two main changes:

• A bug fix for the 'cmd version' command which was not showing any output when the build number was empty. Now, it will display 'unknown' when the build number is not available.

---

PR Main Files Walkthrough:

files:

• cmd/version/version.go: Modified the 'RunE' function in the 'GetVersionCmd' command. Instead of directly using 'cautils.BuildNumber', a 'versionCheckRequest' object is created and used. This ensures that even if the 'BuildNumber' is empty, 'unknown' will be displayed as the version.

[mohaidoss]

/describe

[mohaidoss]

Not sure why I have an unrelated commit on my fork lol 😅

[matthyx]

Not sure why I have an unrelated commit on my fork lol 😅

it probably depends on how you have updated your fork... can you try:

git fetch upstream && git rebase upstream/master

[mohaidoss]

Not sure why I have an unrelated commit on my fork lol 😅

it probably depends on how you have updated your fork... can you try:

git fetch upstream && git rebase upstream/master

Thank you ! It helped

[matthyx]

/review

[github-actions]

PR Analysis

• 🎯 Main theme: Fixing a bug in the 'cmd version' command that was not showing any output when the build number was empty.
• 📝 PR summary: This PR addresses a bug in the 'cmd version' command where no output was displayed if the build number was empty. The fix ensures that 'unknown' is displayed as the version when the build number is not available. The PR also includes tests for the changes made.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 2, because the PR is small and the changes are straightforward, focusing on a single functionality.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR is well-structured and the changes are clear. The addition of tests for the changes made is commendable. However, it would be beneficial to add some comments in the code to explain the changes made, especially for future reference.

• 🤖 Code feedback:

  • relevant file: cmd/version/version.go
    suggestion: Consider handling the error returned by 'fmt.Fprintf'. Ignoring this error might lead to unexpected behaviors. [important]
    relevant line: fmt.Fprintf(cmd.OutOrStdout(),

  • relevant file: cmd/version/version_test.go
    suggestion: It would be better to use 'assert.Equal' from the 'testify' package for comparing expected and actual results. It provides better error messages and reduces the amount of code. [medium]
    relevant line: if string(out) != tt.want {

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[matthyx]

few nits, also please squash your commits

[matthyx]

well done @mohaidoss !