Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scanning repo #1680

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix scanning repo #1680

merged 1 commit into from
May 7, 2024

Conversation

dwertent
Copy link
Contributor

@dwertent dwertent commented May 6, 2024

Overview

We encountered several issues with repository scanning:

  1. Scanning a remote repository resulted in the scanning process occurring on the remote repository, but the scanning metadata was stored in the current directory from which we initiated the scan.
  2. There was confusion between local scanning and repository scanning, leading to numerous unpredictable behaviors.
  3. The output file paths were incorrect.

@dwertent
fix scanning repo
3cbd2c4 
Signed-off-by: David Wertenteil <dwertent@armosec.io>
matthyx
matthyx approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@dwertent dwertent merged commit da6faa3 into master May 7, 2024
10 checks passed
@matthyx matthyx deleted the fix/repo-scanning branch May 23, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dwertent @matthyx