Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Fixed when downloading on azure cloud vm environment #720

Merged
merged 4 commits into from Sep 1, 2023

Conversation

pwnb0y
Copy link
Contributor

@pwnb0y pwnb0y commented Aug 29, 2022

Describe your changes

In some windows os install.ps1 through error due to dependency on internet explorer engine.
That error is fixed now

Screenshots - If Any (Optional)

Issue ticket number and link

#717 #717

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

Please open the PR against the dev branch (Unless the PR contains only documentation changes)

@havardj900
Copy link

Please unsubscribe me I'm just not smart 3n9ygh for this

@dwertent dwertent changed the base branch from dev to master September 15, 2022 13:21
@dwertent dwertent added feature New feature or request todo Feature/fix that should be added to the roadmap development labels Sep 15, 2022
@dwertent
Copy link
Contributor

dwertent commented Nov 2, 2022

In some windows os install.ps1 through error due to dependency on internet explorer engine

Can you please elaborate? Did you confirm this does not break the installation on other windows machines?

@dwertent dwertent added the Install Kubescape install label Nov 2, 2022
@pwnb0y
Copy link
Contributor Author

pwnb0y commented Nov 6, 2022

Ya, I am sure it does not break

@pwnb0y
Copy link
Contributor Author

pwnb0y commented Nov 6, 2022

Hey @dwertent I design the code in such a way that if my method does't works on any os then it will switch to previous stuff😐

@pwnb0y
Copy link
Contributor Author

pwnb0y commented Nov 6, 2022

If you want any more to change in script then please let me know.

Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@craigbox
Copy link
Contributor

@dwertent ready to merge?

@HollowMan6 FYI in case you want to look at this

Copy link
Contributor

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested that in Windows Sandbox and everything works OK, so I can help confirm this does not break the installation on other windows machines.

image

@craigbox
Copy link
Contributor

craigbox commented Aug 4, 2023

I think this PR isn't required any more as further versions have added BitsTransfer support?

@pwnb0y are you still around to confirm?

@dwertent dwertent merged commit 6a8a338 into kubescape:master Sep 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Install Kubescape install todo Feature/fix that should be added to the roadmap development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants