-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on pre-configured killercoda's ubuntu playground (added documentation & Link to readme) #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Welcome to this repo, Congratulations on opening your Pull Request. Keep Contributing to Kubescape
We'll try to review and add you work as soon as possible and a maintainer will get back to you soon!
Hi @slashben, Could you please review this? |
If you want to preview the changed README.md file, visit this link, look under |
README.md
Outdated
|
||
|
||
* Clone the official GitHub repository of `Kubescape`. | ||
* Install cmake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should link here to the Build on Linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dwertent , I have made the changes you suggested.
README.md
Outdated
<summary>Instructions to use the playground</summary> | ||
|
||
* Apply changes you wish to make to the kubescape directory using text editors like `Vim`. | ||
* Execute `make build` after the changes. (This will build the `kubescape` binary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here again, we should have a single place of instructions on how to build
Build on pre-configured killercoda's ubuntu playground
Pre-configured Killercoda's Ubuntu Playground
For people having trouble building in their local machines, killercoda's ubuntu playground will be extremely useful. But, as you know the playground lasts for only 60 minutes. Executing each command manually every hour is not a pleasant experience. So, I've created this custom playground. The user just had to start the playground and wait for 5-6 minutes.
Pre-programmed actions executed by the playground
Kubescape
.libgit2
dependency inside 'kubescape' directory.make build
inside 'kubescape' directory.Instructions to use the playground
Vim
.make build
after the changes. (This will build thekubescape
binary)kubescape
, use./kubescape
. (Make sure you are inside kubescape directory because the command will execute the binary namedkubescape
inkubescape directory
.