Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stretchr/testify instead of gotest #110

Merged
merged 2 commits into from
May 23, 2023
Merged

use stretchr/testify instead of gotest #110

merged 2 commits into from
May 23, 2023

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented May 23, 2023

this one you will like...

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx requested a review from vladklokun May 23, 2023 14:16
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
Copy link
Contributor Author

matthyx commented May 23, 2023

I have added a second commit to also replace deep.Equal

Copy link
Collaborator

@vladklokun vladklokun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@matthyx matthyx merged commit a2503a1 into main May 23, 2023
7 of 8 checks passed
@matthyx matthyx deleted the testify branch May 23, 2023 15:20
dwertent pushed a commit that referenced this pull request Dec 31, 2023
use stretchr/testify instead of gotest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants