Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve labels and annotations from storage #123

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Jun 7, 2023

fixes system tests and probably other bugs

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@dwertent dwertent added the release Create release label Jun 7, 2023
Copy link
Contributor

@dwertent dwertent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we did not detect the issue in a unit test.

@matthyx
Copy link
Contributor Author

matthyx commented Jun 7, 2023

I made sure we cover that too

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent dwertent merged commit 21b939e into main Jun 7, 2023
7 of 8 checks passed
@matthyx matthyx deleted the missing-labels branch June 8, 2023 05:28
dwertent added a commit that referenced this pull request Dec 31, 2023
retrieve labels and annotations from storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants