Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalizd image tag correction #138

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

rcohencyberarmor
Copy link
Contributor

Overview

rcohencyberarmor added 2 commits August 14, 2023 16:01
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
@codiumai-pr-agent
Copy link

PR Analysis

  • 🎯 Main theme: Normalizing image tags in the registry
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: True
  • Focused PR: Yes, the PR is focused on normalizing image tags in the registry.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: The PR seems to be well-structured and focused on a specific enhancement. The changes are well-documented and relevant tests have been added. Good job on maintaining code quality and ensuring test coverage.

  • 🤖 Code feedback:

    • relevant file: controllers/http.go
      suggestion: Consider using a constructor function for creating a new instance of ScanCommand. This will improve code readability and maintainability. [medium]
      relevant line: command := domain.ScanCommand{

    • relevant file: controllers/http_test.go
      suggestion: Consider using table-driven tests to reduce code repetition and improve test maintainability. [medium]
      relevant line: tests := []struct {

    • relevant file: internal/tools/tools_test.go
      suggestion: It would be better to add more edge cases in your tests to ensure the robustness of your function. [medium]
      relevant line: want: "public-registry.systest-ns-na6n:5000/nginx:test",

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@github-actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@dwertent dwertent added the release Create release label Aug 14, 2023
@dwertent dwertent merged commit c086e93 into main Aug 14, 2023
6 of 7 checks passed
@dwertent dwertent deleted the normalizd-image-tag-correction branch December 13, 2023 11:02
dwertent pushed a commit that referenced this pull request Dec 31, 2023
* add normalized image tag to the registry as well

Signed-off-by: rcohencyberarmor <rcohen@armosec.io>

* add test case for registry that run on our system test

Signed-off-by: rcohencyberarmor <rcohen@armosec.io>

---------

Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Co-authored-by: rcohencyberarmor <rcohen@armosec.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants