Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard relevant SBOM based on validating func #98

Merged
merged 1 commit into from
Apr 17, 2023
Merged

discard relevant SBOM based on validating func #98

merged 1 commit into from
Apr 17, 2023

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Apr 17, 2023

also don't discard if sbom tool version is different

@github-actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx changed the title do not discard relevant SBOM created by older syft discard relevant SBOM based on validating func Apr 17, 2023
@@ -190,6 +191,13 @@ func (a *APIServerStore) GetSBOM(ctx context.Context, imageID, SBOMCreatorVersio
return result, nil
}

func validateSBOMp(manifest *v1beta1.SBOMSPDXv2p3Filtered) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwertent this is where you should make your changes

@matthyx matthyx requested a review from dwertent April 17, 2023 09:59
@github-actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent dwertent merged commit 023ec2e into main Apr 17, 2023
@matthyx matthyx deleted the sbomp branch April 17, 2023 12:53
dwertent added a commit that referenced this pull request Dec 31, 2023
discard relevant SBOM based on validating func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants