Remove global ,format Topics , consumer options and base test suite #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary:
|
|
/describe |
Bezbran
requested changes
Aug 24, 2023
Bezbran
requested changes
Aug 24, 2023
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
Bezbran
requested changes
Aug 24, 2023
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
Bezbran
previously approved these changes
Aug 27, 2023
avrahams
changed the title
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
Signed-off-by: Avraham Shalev <8184528+avrahams@users.noreply.github.com>
|
Summary:
|
1 similar comment
|
Summary:
|
Bezbran
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove global client and config
Add Client, Consumer and Producers interfaces that wraps pulsar types
Add Client methods to create consumers and producers
Handle topics format in Producer and consumer constructors
Improve consumer options
Create base test suite