Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only check latest kubescape version if user choose so #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeffmou787
Copy link

Hi, thanks for this useful extension and our group are all eager to use it.

Since we are under an air-gapped environment, we already prepared a proxy for VS Code extension installing. However, since the extension will try to check the kubescape binary version during initialization, it is still stucked and we has no other methods to solve it.

I think maybe only to check latest version when user fill in "latest" option in the extension config is a reasonable solution ?

Please let me know your thoughts, thx :)

Signed-off-by: jeffmou787 <dingyanmao@gmail.com>
…t" in VS Code config

Signed-off-by: jeffmou787 <dingyanmao@gmail.com>
@jeffmou787
Copy link
Author

Another thought: let VSCode user can customize PACKAGE_BASE_URL & PACKAGE_DOWNLOAD_BASE_URL, so they can use the extension with private repo or air-gapped env.

@amirmalka
Copy link
Collaborator

amirmalka commented Nov 12, 2023

@jeffmou787 I appreciate your feedback and understand the challenges you're facing in an air-gapped environment.

I would have to say that I think that customizing the URLs as you suggested might be a better idea for air-gapped environments as it would provide users with more flexibility and better support for different use cases.
WDYT?

@jeffmou787
Copy link
Author

@jeffmou787 I appreciate your feedback and understand the challenges you're facing in an air-gapped environment.

I would have to say that I think that customizing the URLs as you suggested might be a better idea for air-gapped environments as it would provide users with more flexibility and better support for different use cases. WDYT?

Thanks for the reply @amirmalka .

To customize the URLs I think is better, but also has more work to do. I think there will be two URLs options to be added: URL_FOR_KUBESCAPE_BINARY_DOWNLOAD and URL_FOR_FRAMEWORKS_DOWNLOAD. Since our group use private Gitlab as git repo, the API infos seems different compare to Github (For example, Gitlab API project result json response do not have "html_url" key), the codes need some changes.

If an user fill in URL_FOR_KUBESCAPE_BINARY_DOWNLOAD, then the code will ignore those version validations, download the binary from URL instead directly. Same as for frameworks dowloads (URL_FOR_FRAMEWORKS_DOWNLOAD).

The kubescape-vscode repo also need commits to add these options.

Do you guys has resources to deal with it? If not I can do it since my team want to add the kubescape extesion into our development cycle ASAP.

Please tell me your thoughts, thank you.

@amirmalka
Copy link
Collaborator

@jeffmou787 Integrating those URL options aligns with our plans, but due to current resource constraints, we won't be able to address it in the coming 1-2 months. Feel free to contribute, and we'll do our best to review and merge. Appreciate your understanding and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants