Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platformPackages config #11

Merged
merged 1 commit into from Aug 2, 2023
Merged

Remove platformPackages config #11

merged 1 commit into from Aug 2, 2023

Conversation

HollowMan6
Copy link
Contributor

I'm not sure whether the platformPackages config is still needed here.

Since we are adding the arm64 binaries support, if it's still needed, maybe we shall find a way to represent those arm64 binaries as well.

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6 HollowMan6 requested a review from amirmalka May 1, 2023 15:15
Copy link
Contributor

@amirmalka amirmalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with approving this PR, did you have a chance to test that it doesn't break the extension?

@HollowMan6
Copy link
Contributor Author

did you have a chance to test that it doesn't break the extension?

I haven't, but since I'm not sure why we have the platformPackages config here still, I will try to figure out that first.

@HollowMan6
Copy link
Contributor Author

I have tested this PR and can confirm it doesn't break the extension.

@amirmalka amirmalka merged commit c597a31 into kubescape:master Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants