Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/kusk/cmd/dashboard.go: Does not use dashboardEnvoyFleetExternalPort #1034

Open
mbana opened this issue Dec 15, 2022 · 0 comments
Open

cmd/kusk/cmd/dashboard.go: Does not use dashboardEnvoyFleetExternalPort #1034

mbana opened this issue Dec 15, 2022 · 0 comments

Comments

@mbana
Copy link
Contributor

mbana commented Dec 15, 2022

https://github.com/kubeshop/kusk-gateway/blob/main/cmd/kusk/cmd/dashboard.go#L158 doesn't use the dashboardEnvoyFleetExternalPort.

If I change it to the below it opens the dashboard when port 8080 has already been allocated but the dashboard at http://localhost:8081/ doesn't show the APIs.

    browserOpenCMD, browserOpenArgs := getBrowserOpenCmdAndArgs(fmt.Sprintf("http://localhost/:%d", dashboardEnvoyFleetExternalPort))`

Hence I am reluctant to make the "fix".

Steps to Reproduce

  1. Apply the fix above to cmd/kusk/cmd/dashboard.go.
  2. Port forward to 8080, e.g., kubectl port-forward --namespace kusk-system services/kusk-gateway-envoy-fleet 8080:80.
  3. Launch dashboard and attempt to browse an API and note that nothing is shown. The command below launches the dashboard and prints the output after applying the "fix". Observe that it has been allocated port 8081:
$ kusk dashboard                                                                 
Forwarding from 127.0.0.1:8081 -> 8080
Forwarding from [::1]:8081 -> 8080
Handling connection for 8081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant