Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not possible to change only Git token or Git username for Test Source #3814

Closed
rangoo94 opened this issue May 11, 2023 · 1 comment · Fixed by #3896
Closed

It's not possible to change only Git token or Git username for Test Source #3814

rangoo94 opened this issue May 11, 2023 · 1 comment · Fixed by #3896
Assignees
@vsukhin
Labels
bug 🐛 Something is not working as should be service:api 🎡

Comments

@rangoo94
Copy link
Member

Describe the bug

When both username and token secrets, are set, PATCHing with token: "" or username: "" resets both.

To Reproduce

Steps to reproduce the behavior:

  1. Create a test source with username and token secrets
  2. Patch the token via API
  3. See that none of secrets are attached

Expected behavior

It should apply only expected changes.
@rangoo94 rangoo94 added bug 🐛 Something is not working as should be service:api 🎡 labels May 11, 2023
@vsukhin vsukhin self-assigned this May 12, 2023
@vsukhin vsukhin mentioned this issue May 25, 2023
Merged
6 tasks
@tkonieczny
Copy link
Contributor

Issue found while testing this one: #3934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsukhin vsukhin

Labels
bug 🐛 Something is not working as should be service:api 🎡
Projects
Testkube
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check username and token for update kubeshop/testkube
3 participants
@tkonieczny @rangoo94 @vsukhin