Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calls to the EventEmitter on Test spec execution (RESOLVE events) #2286

Closed
danielbdias opened this issue Mar 31, 2023 · 1 comment · Fixed by #2292, #2309 or #2311
Closed

Add calls to the EventEmitter on Test spec execution (RESOLVE events) #2286

danielbdias opened this issue Mar 31, 2023 · 1 comment · Fixed by #2292, #2309 or #2311
Assignees
@mathnogueira
Labels
backend

Comments

@danielbdias
Copy link
Contributor

On this task, we should handle the following examples:

Stage Event Type Description Definition
Test RESOLVE_START Resolving test specs details start
Test RESOLVE_SUCCESS Resolving test specs details success
Test RESOLVE_ERROR An error occurred while parsing the test specs
@danielbdias danielbdias mentioned this issue Mar 31, 2023
Closed
2 tasks
@mathnogueira
Copy link
Member

This was removed because there's no resolution phase when running assertions. Value resolution is part of the expression expansion. However, I added events in case of failing assertions so we can report back to the user why the assertion failed (invalid syntax, missing value, etc)

@mathnogueira mathnogueira self-assigned this Apr 4, 2023
This was linked to pull requests Apr 4, 2023
feat: make expression package return ErrExpressionResolution when resolution fails #2292
Merged
feat: emit assertion errors #2309
Merged
feat: emit error event when expression engine return parsing errors #2311
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathnogueira mathnogueira

Labels
backend
Projects
None yet
Milestone
No milestone
2 participants
@mathnogueira @danielbdias