Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI Improvements] add validations for command's flags and arguments #2305

Closed
Tracked by #2182
schoren opened this issue Apr 3, 2023 · 0 comments · Fixed by #2600
Closed
Tracked by #2182

[CLI Improvements] add validations for command's flags and arguments #2305

schoren opened this issue Apr 3, 2023 · 0 comments · Fixed by #2600
Assignees
Labels

Comments

@schoren
Copy link
Collaborator

schoren commented Apr 3, 2023

Commands have a well defined set of flags and/or arguments, and what they should look like.

We currently validate one parameter at a time, so if a user has 2 incorrect parameters, they need to run the command once, see the 1st error, fix it. Run the command again, see the 2nd error, fix it. Run the command again.

We can validate the entire command parameters at once, and show all errors at once, so the user doesn't need to do multiple retries for the same command.

@schoren schoren mentioned this issue Apr 3, 2023
19 tasks
@xoscar xoscar changed the title add validations for command's flags and arguments [CLI Improvements] add validations for command's flags and arguments Apr 10, 2023
@xoscar xoscar added the CLI label Apr 10, 2023
@xoscar xoscar self-assigned this May 9, 2023
@xoscar xoscar linked a pull request May 26, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants