Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when token passed is empty #89

Merged
merged 5 commits into from
Apr 25, 2023
Merged

fix: error when token passed is empty #89

merged 5 commits into from
Apr 25, 2023

Conversation

riteshsonawane1372
Copy link
Contributor

@riteshsonawane1372 riteshsonawane1372 commented Apr 23, 2023 •
edited by dipankardas011
Loading

Tasks / Issue 🚧 🔧

Solution ✔️

Screenshots 🖼️

Note to reviewers 📓

@riteshsonawane1372
Copy link
Contributor Author

@dipankardas011 Have tested it working good

@dipankardas011 dipankardas011 changed the title fix #79 fix(api): error when token passed is empty #79 Apr 23, 2023
@dipankardas011 dipankardas011 changed the title fix(api): error when token passed is empty #79 fix(api): error when token passed is empty Apr 23, 2023
dipankardas011
dipankardas011 requested changes Apr 23, 2023
View reviewed changes
api/utils/main.go Outdated Show resolved Hide resolved
dipankardas011
dipankardas011 requested changes Apr 24, 2023
View reviewed changes
api/utils/main.go Outdated Show resolved Hide resolved
@dipankardas011 dipankardas011 added this to the Release 1.0 milestone Apr 24, 2023
dipankardas011
dipankardas011 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipankardas011 dipankardas011 added pr/mergable This PR is waiting to get merged pr/lgtm This PR look good to the reviewer and removed pr/not-mergable labels Apr 25, 2023
@dipankardas011
Copy link
Member

@riteshsonawane1372 the your commits must be signed

@dipankardas011 dipankardas011 merged commit 8b5d935 into ksctl:main Apr 25, 2023
@dipankardas011 dipankardas011 changed the title fix(api): error when token passed is empty fix: error when token passed is empty May 23, 2023
dipankardas011 pushed a commit that referenced this pull request Jan 9, 2024
@riteshsonawane1372
fix(api): error when token passed is empty (#89)
bd50922 
* fixes ksctl cred
* added logging.err
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipankardas011 dipankardas011 dipankardas011 approved these changes

Assignees
No one assigned
Labels
area/internal cloud/azure azure cloud/civo cloud kind/bug_fix pr/lgtm This PR look good to the reviewer pr/mergable This PR is waiting to get merged priority/high highest priority
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@riteshsonawane1372 @dipankardas011