-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add homepage(main) for the website #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: resolved suggested changes
It is according to the design but if you are talking about the inspect mode so the zoom percentage is 100% that is the reason it is looking big. |
In the design the space above the images and below images are more where as here it is less when I say space I mean space between the navbar and image and space between image and below component also for video content and log content space above and below is more in the design |
I believe that the space thing is not that important because images here have to be absolute and the above space part can be fixed once the navbar is done also the below space part is fine if I am not wrong 🤔. As long as you know where the component is ending and starting space height won't affect. |
See smaller size image looks better so if we can we should |
any updates @SuperAayush |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Yes sure! We can keep working on the page, after the PR has been merged as well! |
Thanks for contributing @SuperAayush & for helping @AvineshTripathi :) |
Closes #7
Modified the landing page of the website.
This is how the page looks in full-screen mode :
1/2
2/2
This is how the page looks in inspect mode :
cc @verma-kunal @AvineshTripathi