Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add homepage(main) for the website #33

Merged
merged 3 commits into from
May 14, 2022

Conversation

SuperAayush
Copy link
Contributor

@SuperAayush SuperAayush commented May 7, 2022

Closes #7

Modified the landing page of the website.

This is how the page looks in full-screen mode :
1/2
Screenshot 2022-05-08 at 2 10 58 AM
2/2
Screenshot 2022-05-08 at 2 11 16 AM

This is how the page looks in inspect mode :

Screenshot 2022-05-08 at 2 14 48 AM

cc @verma-kunal @AvineshTripathi

@anubha-v-ardhan anubha-v-ardhan added this to In progress in KubeSimplify's website via automation May 8, 2022
@anubha-v-ardhan anubha-v-ardhan added the enhancement New feature or request label May 8, 2022
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images shown in the top most part are too big in comparison to the design, is it intensional?

__
sema-logo  Summary: ❓ I have a question

src/components/HomepageFeatures/index.js Outdated Show resolved Hide resolved
src/components/HomepageFeatures/index.js Outdated Show resolved Hide resolved
fix: resolved suggested changes
@SuperAayush
Copy link
Contributor Author

SuperAayush commented May 8, 2022

The images shown in the top most part are too big in comparison to the design, is it intensional?

__ sema-logo  ❓ I have a question

It is according to the design but if you are talking about the inspect mode so the zoom percentage is 100% that is the reason it is looking big.

__
sema-logo  Summary: 👌 This code looks good

@AvineshTripathi
Copy link
Collaborator

In the design the space above the images and below images are more where as here it is less when I say space I mean space between the navbar and image and space between image and below component also for video content and log content space above and below is more in the design

@SuperAayush
Copy link
Contributor Author

SuperAayush commented May 8, 2022

In the design the space above the images and below images are more where as here it is less when I say space I mean space between the navbar and image and space between image and below component also for video content and log content space above and below is more in the design

I believe that the space thing is not that important because images here have to be absolute and the above space part can be fixed once the navbar is done also the below space part is fine if I am not wrong 🤔. As long as you know where the component is ending and starting space height won't affect.

@AvineshTripathi
Copy link
Collaborator

See smaller size image looks better so if we can we should

@AvineshTripathi
Copy link
Collaborator

any updates @SuperAayush

@AvineshTripathi
Copy link
Collaborator

AvineshTripathi commented May 10, 2022

LGTM!

p.s. the changes mentioned above would be done in furthur PRs

__
sema-logo  Summary: 🛠️ This code needs a fix

Copy link
Collaborator

@verma-kunal verma-kunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

KubeSimplify's website automation moved this from In progress to Reviewer approved May 14, 2022
@verma-kunal
Copy link
Collaborator

verma-kunal commented May 14, 2022

LGTM!

p.s. the changes mentioned above would be done in furthur PRs

Yes sure! We can keep working on the page, after the PR has been merged as well!
So, thats not an issue
cc @saiyam1814

@verma-kunal
Copy link
Collaborator

Thanks for contributing @SuperAayush & for helping @AvineshTripathi :)

@verma-kunal verma-kunal merged commit 241ba2f into kubesimplify:main May 14, 2022
KubeSimplify's website automation moved this from Reviewer approved to Done May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

feat: add homepage(main) for the website
4 participants