Issue #49 Resolved (Footer) #51
Conversation
src/theme/Footer/index.js
Outdated
| @@ -6,6 +6,15 @@ | |||
| */ | |||
| import React from 'react'; | |||
| import styles from './styles.module.css'; // CSS modules | |||
| import { BsInstagram } from "react-icons/bs"; | |||
There was a problem hiding this comment.
Where is this import used
There was a problem hiding this comment.
Ok I have corrected this also.
src/theme/Footer/index.js
Outdated
| <a target="_blank" href="https://www.linkedin.com/company/kubesimplify/"><TiSocialLinkedin row="img" className={styles.social2}/></a> | ||
| <a target="_blank" href="https://www.instagram.com/saiyampathak/"><AiOutlineInstagram row="img" className={styles.social2}/></a> | ||
| <a target="_blank" href="https://github.com/kubesimplify"><AiFillGithub row="img" className={styles.social3}/></a> | ||
| {/* <a href="#"><logo.instagram.Svg row="img" className={styles.social} /></a> |
There was a problem hiding this comment.
Why are we commenting these line and not removing these
There was a problem hiding this comment.
I have removed these lines now, and they will reflect in my next commit.
Actually @AvineshTripathi I didn’t work on the responsive thing because it was already not responsive initially, But ok I’ll look into it and will push my changes after doing the work that you suggested. |
|
Hey @Jai-Solania-29 any updates |
|
Hey @AvineshTripathi actually I'm having my exams these days so I'm little busy right now. I was thinking may be you can merge this PR for now, and I'll open a different issue for responsiveness of the footer so that someone else can work on that if interested, Otherwise I'll start working on this issue in next couple of days. |
Sounds good to me! |
|
All the best @Jai-Solania-29 for exams and thanks for notifying LGTM P.S. i ll create an issue for it after merge |
|
Thank you @AvineshTripathi , I have my last exam tomorrow. So once you create an issue I’ll start working on that. |
|
Hey @AvineshTripathi any updates ? |
|
Hey @Jai-Solania-29 sorry for the delay, can you create issue and start working or i should create issue? |
|
Hey @AvineshTripathi I’ll create an issue and will start working on that , but that is only possible when my PR gets merged. I mean the actual footer will reflect after my PR gets merged, and only then I can open an issue for making the footer responsive, and will start working on that . |
|
can you make the positioning relative and not absolute cc @verma-kunal |
I believe this change hasn't been done yet! @Jai-Solania-29 can you pls check this one :) |
Hey @verma-kunal I have pushed the requested changes, Kindly check and merge. __ |
|
Thanks for contributing @Jai-Solania-29 ✨ |
* Issue kubesimplify#49 Resolved (Footer) * Position Changed from Absolute to Relative
Fixes Issue
Closes #49
Changes proposed
Social Icons in the footer are now accurate and according to the design of the website.
Redirection links are given to the social icons, and they all are in working state following the target blank property.
Footer Size is modified according to the official design of the website.
Alignment of text and sponsor card fixed.
Sponsor Card size is modified according to the official design of the website.
Design of Sponsor Card is also modified and its now accurate and according to the design o the website.
Font Size is modified according to the design of the website.
Screenshots
Previous Footer:
Current Footer :
Note to reviewers
cc- @AvineshTripathi @verma-kunal @SuperAayush
Previously SVG format images were used for social icons, but they were not working properly as for all social icons same and only one image was rendering which was in the front line of the code.
So for fixing that issue I have now used React Icons instead of SVG files.