feat(AM-11526,AM-11741): Slice Gateway External LoadBalancer #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulgain
force-pushed
the
feature-slicegw-ext-lb
branch
from
fa4a52e
to
90f4962
Compare
Signed-off-by: Mridul <mridulgain@gmail.com>
mridulgain
force-pushed
the
feature-slicegw-ext-lb
branch
from
90f4962
to
5b20b10
Compare
Signed-off-by: Mridul <mridulgain@gmail.com>
mridulgain
changed the title
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
mridulgain
force-pushed
the
feature-slicegw-ext-lb
branch
from
ca4560e
to
aec07c4
Compare
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
#190) * feat(AM-11741): define protocol for gw svc type * feat(AM-11741): reconcilation logic for gateway service protocol * feat(AM-11741): provide gw protocol during cert generation * fix(AM-11741): webhook validation, env var & wsc reconciler * fix(): gwsvctype mistatch --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com>
mridulgain
force-pushed
the
feature-slicegw-ext-lb
branch
from
514edfd
to
bd3b57c
Compare
mridulgain
requested review from
PuranAdhikari,
priyank-upadhyay and
that-backend-guy
as code owners
mridulgain
changed the title
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
Signed-off-by: Mridul <mridulgain@gmail.com>
narmidm
approved these changes
Nov 23, 2023
narmidm
added a commit
that referenced
this pull request
Nov 23, 2023
* feat(): vpnkeyrotation apis, webhook, ITs, UTs and service layer (#151) feat(): vpnkeyrotation apis, webhook, ITs, UTs and service layer (#151) Signed-off-by: rahulsawra98 <rahul.sawra@aveshasystems.com * Update trivy.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Create codeql.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Update trivy.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Delete codeql.yml Signed-off-by: Md Imran <imranaec@outlook.com> * feat(AM-11526,AM-11741): Slice Gateway External LoadBalancer (#180) * added slicegatewayServiceType field Signed-off-by: Mridul <mridulgain@gmail.com> * added slice config validation Signed-off-by: Mridul <mridulgain@gmail.com> * workerslicegw change: adding gw connectivity type Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): reconcile logic for LB IPs Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): updating gwConnType is not allowed Signed-off-by: Mridul <mridulgain@gmail.com> * set gwSvcType during workersliceconfig creation Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): set gwSvcType during workerSliceGw creation Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): webhook validation not needed in wsc & wsg Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11741): protocol specification for slice gateway load balancer (#190) * feat(AM-11741): define protocol for gw svc type * feat(AM-11741): reconcilation logic for gateway service protocol * feat(AM-11741): provide gw protocol during cert generation * fix(AM-11741): webhook validation, env var & wsc reconciler * fix(): gwsvctype mistatch --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix: edge case Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-12018): unit test for getSliceGwSvcTypes() Signed-off-by: Mridul <mridulgain@gmail.com> * fix(AM-12018): prevent protocol update Signed-off-by: Mridul <mridulgain@gmail.com> * fix(AM-12018): unit tests for validateSlicegatewayServiceType Signed-off-by: Mridul <mridulgain@gmail.com> --------- Signed-off-by: Mridul <mridulgain@gmail.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> --------- Signed-off-by: rahulsawra98 <rahul.sawra@aveshasystems.com Signed-off-by: Mridul <mridulgain@gmail.com> Signed-off-by: Md Imran <imranaec@outlook.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> Co-authored-by: rahulsawra98 <104886535+rahulsawra98@users.noreply.github.com> Co-authored-by: Mridul <mridulgain@gmail.com>
mridulgain
added a commit
that referenced
this pull request
Feb 16, 2024
* feat(): vpnkeyrotation apis, webhook, ITs, UTs and service layer (#151) feat(): vpnkeyrotation apis, webhook, ITs, UTs and service layer (#151) Signed-off-by: rahulsawra98 <rahul.sawra@aveshasystems.com * Update trivy.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Create codeql.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Update trivy.yml Signed-off-by: Md Imran <imranaec@outlook.com> * Delete codeql.yml Signed-off-by: Md Imran <imranaec@outlook.com> * feat(AM-11526,AM-11741): Slice Gateway External LoadBalancer (#180) * added slicegatewayServiceType field Signed-off-by: Mridul <mridulgain@gmail.com> * added slice config validation Signed-off-by: Mridul <mridulgain@gmail.com> * workerslicegw change: adding gw connectivity type Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): reconcile logic for LB IPs Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): updating gwConnType is not allowed Signed-off-by: Mridul <mridulgain@gmail.com> * set gwSvcType during workersliceconfig creation Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): set gwSvcType during workerSliceGw creation Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11526): webhook validation not needed in wsc & wsg Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-11741): protocol specification for slice gateway load balancer (#190) * feat(AM-11741): define protocol for gw svc type * feat(AM-11741): reconcilation logic for gateway service protocol * feat(AM-11741): provide gw protocol during cert generation * fix(AM-11741): webhook validation, env var & wsc reconciler * fix(): gwsvctype mistatch --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix: edge case Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-12018): unit test for getSliceGwSvcTypes() Signed-off-by: Mridul <mridulgain@gmail.com> * fix(AM-12018): prevent protocol update Signed-off-by: Mridul <mridulgain@gmail.com> * fix(AM-12018): unit tests for validateSlicegatewayServiceType Signed-off-by: Mridul <mridulgain@gmail.com> --------- Signed-off-by: Mridul <mridulgain@gmail.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(AM-12145): prevent protocol update Signed-off-by: Mridul <mridulgain@gmail.com> * feat(AM-12243): controller changes for envoy gw (#196) * feat(): api changes for envoy gw Signed-off-by: Mridul <mridulgain@gmail.com> * feat(): adding new fields to support multinet slice Signed-off-by: Mridul Gain <mridulgain@gmail.com> --------- Signed-off-by: Mridul <mridulgain@gmail.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> --------- Signed-off-by: rahulsawra98 <rahul.sawra@aveshasystems.com Signed-off-by: Mridul <mridulgain@gmail.com> Signed-off-by: Md Imran <imranaec@outlook.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> Co-authored-by: rahulsawra98 <104886535+rahulsawra98@users.noreply.github.com> Co-authored-by: Md Imran <imranaec@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Controller changes for Slice Gateway External LoadBalancer implementation
SliceGatewayServiceTypeinSliceConfig&WorkerSliceConfigFixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a breaking change for other components like worker-operator?