Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check cicd clustertemplate jenkinsfile failed #80

Merged
merged 1 commit into from
Oct 21, 2022
Merged

fix check cicd clustertemplate jenkinsfile failed #80

merged 1 commit into from
Oct 21, 2022

Conversation

chilianyi
Copy link
Contributor

fix: #79

@chilianyi
Copy link
Contributor Author

/assign @LinuxSuRen

@chilianyi chilianyi marked this pull request as draft October 17, 2022 15:50
@chilianyi chilianyi marked this pull request as ready for review October 17, 2022 15:56
LinuxSuRen
LinuxSuRen reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you here. I will test it locally later. Please ping me again if I didn't finish it this week.

@zheng1
Copy link

zheng1 commented Oct 21, 2022

/approve
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm label Oct 21, 2022
@ks-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chilianyi, zheng1
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chilianyi chilianyi merged commit e2cf426 into kubesphere-sigs:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

Assignees

@LinuxSuRen LinuxSuRen

@zheng1 zheng1

Labels
lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Falied to check cicd clustertemplate in release ks-devops-0.1.13
4 participants
@chilianyi @zheng1 @ks-ci-bot @LinuxSuRen