Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the communication issue between ks-devops and Jenkins #34

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Jul 6, 2021

There're three changes you can find in this PR:

  • provide a constant password for the admin user
  • make the default security realm be local instead of LDAP
    • we will support OIDC later
  • provide a correct server address for the KubeSphere token server

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #34 (4e3cb7e) into master (22926b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #34   +/-   ##
======================================
  Coverage    4.98%   4.98%           
======================================
  Files          64      64           
  Lines       19996   19996           
======================================
  Hits          996     996           
  Misses      18931   18931           
  Partials       69      69           
Flag Coverage Δ
unittests 4.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/client/k8s/kubernetes.go 10.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22926b5...4e3cb7e. Read the comment docs.

@LinuxSuRen
Copy link
Member Author

hi @JohnNiang , please help me to review this PR. Thanks!

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @JohnNiang , please help me to review this PR. Thanks!

WIP.

charts/ks-devops/charts/jenkins/templates/_helpers.tpl Outdated Show resolved Hide resolved
@JohnNiang
Copy link
Member

LGTM

@LinuxSuRen LinuxSuRen merged commit 93e8b69 into master Jul 7, 2021
@LinuxSuRen LinuxSuRen deleted the fix-jenkins-auth branch July 7, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants