Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the homebrew part due to this is not belong to linuxsuren #212

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

LinuxSuRen
Copy link
Contributor

No description provided.

@JohnNiang
Copy link
Contributor

Do the following configurations also need to be changed?

ks/.goreleaser.yml

Lines 18 to 21 in ff46ca7

ldflags:
- -X github.com/linuxsuren/cobra-extension/version.version={{.Version}}
- -X github.com/linuxsuren/cobra-extension/version.commit={{.ShortCommit}}
- -X github.com/linuxsuren/cobra-extension/version.date={{.Date}}

ks/.goreleaser.yml

Lines 36 to 39 in ff46ca7

ldflags:
- -X github.com/linuxsuren/cobra-extension/version.version={{.Version}}
- -X github.com/linuxsuren/cobra-extension/version.commit={{.ShortCommit}}
- -X github.com/linuxsuren/cobra-extension/version.date={{.Date}}

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@bdbf7c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #212   +/-   ##
========================================
  Coverage          ?   9.20%           
========================================
  Files             ?      32           
  Lines             ?    1390           
  Branches          ?       0           
========================================
  Hits              ?     128           
  Misses            ?    1252           
  Partials          ?      10           
Flag Coverage Δ
unittests 9.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbf7c7...ff46ca7. Read the comment docs.

@LinuxSuRen
Copy link
Contributor Author

Do the following configurations also need to be changed?

No.

Those flags are used to set the version.

@JohnNiang
Copy link
Contributor

/lgtm

@LinuxSuRen LinuxSuRen merged commit 864ac6f into kubesphere-sigs:master Sep 27, 2021
@LinuxSuRen LinuxSuRen deleted the remove-brew branch September 27, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants