Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version check when install ks with kubekey #232

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

LinuxSuRen
Copy link
Contributor

No description provided.

@LinuxSuRen LinuxSuRen added the bug Something isn't working label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@3f8ecfc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   10.54%           
=========================================
  Files             ?       33           
  Lines             ?     1451           
  Branches          ?        0           
=========================================
  Hits              ?      153           
  Misses            ?     1285           
  Partials          ?       13           
Flag Coverage Δ
unittests 10.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8ecfc...eab8623. Read the comment docs.

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although it doesn't work by default because kks released don't support prerelease version currently, the change looks good to me.

[root@node1 ~]# ./ks install kk --zone="" -v v3.2.0-rc.1
start to install missing tool: kk
start to fetch the config
Enumerating objects: 265, done.
Counting objects: 100% (265/265), done.
Compressing objects: 100% (232/232), done.
Total 265 (delta 129), reused 78 (delta 25), pack-reused 0
start to download with 4 threads, size: 13341858, unit: 3335464
Downloading part 1:  [====================================================================] 100%
Downloading part 3:  [====================================================================] 100%
Downloading part 2:  [====================================================================] 100%
Downloading part 0:  [====================================================================] 100%
install ./kk to /usr/local/bin/kk
Error: Failed to download cluster config: Unsupported version: v3.2.0-rc.1

https://github.com/kubesphere/kubekey/releases/tag/v1.2.0-alpha.6

@LinuxSuRen
Copy link
Contributor Author

Although it doesn't work by default because kks released don't support prerelease version currently, the change looks good to me.

You can install it via: hd install kubekey --accept-preReleas

@LinuxSuRen LinuxSuRen merged commit 88e11d9 into kubesphere-sigs:master Oct 21, 2021
@LinuxSuRen LinuxSuRen deleted the fix-kk-version-check branch October 21, 2021 08:17
@JohnNiang
Copy link
Contributor

Although it doesn't work by default because kks released don't support prerelease version currently, the change looks good to me.

You can install it via: hd install kubekey --accept-preRelease

Thank you for your reminder. I'm going to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants