Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add 'select all' option when deleting related resource of a specified workload #1933

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix: Add 'select all' option when deleting related resource of a specified workload #1933

merged 1 commit into from
Jun 25, 2021

Conversation

fuchunlan
Copy link
Contributor

Signed-off-by: lannyfu lannyfu@yunify.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##1735

Special notes for reviewers:

Additional documentation, usage docs, etc.:

2021-06-07.4.35.21.mov

@fuchunlan
fix: Add 'select all' option then deleting related resource of a spec…
c4fad2e 
…ified workload

Signed-off-by: lannyfu <lannyfu@yunify.com>
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2021
@fuchunlan fuchunlan changed the title fix: Add 'select all' option then deleting related resource of a specified workload fix: Add 'select all' option when deleting related resource of a specified workload Jun 7, 2021
@harrisonliu5
Copy link
Collaborator

/assign @zheng1

@harrisonliu5
Copy link
Collaborator

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuchunlan, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@zheng1
Copy link
Member

zheng1 commented Jun 16, 2021

/deploy

@zheng1
Copy link
Member

zheng1 commented Jun 25, 2021

/lgtm
/cherrypick release-3.1

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@ks-ci-bot ks-ci-bot merged commit 28526e4 into kubesphere:master Jun 25, 2021
@ks-ci-bot
Copy link
Collaborator

@zheng1: once the present PR merges, I will cherry-pick it on top of release-3.1 in a new PR and assign it to you.

In response to this:

/lgtm
/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Jun 25, 2021
Merged
@ks-ci-bot
Copy link
Collaborator

@zheng1: new pull request created: #2027

In response to this:

/lgtm
/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zheng1 zheng1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fuchunlan @harrisonliu5 @ks-ci-bot @zheng1