Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify the desc of app on locales file. #2012

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

fuchunlan
Copy link
Contributor

Signed-off-by: lannyfu lannyfu@yunify.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
To add a hint of the maximum length limit for the input field in the Edit Application Template page.

Which issue(s) this PR fixes:

Fixes ##kubesphere/kubesphere/3536

Special notes for reviewers:

Additional documentation, usage docs, etc.:


Signed-off-by: lannyfu <lannyfu@yunify.com>
@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2021
@harrisonliu5
Copy link
Collaborator

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuchunlan, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@ks-ci-bot ks-ci-bot merged commit 864c1e4 into kubesphere:master Jun 24, 2021
@fuchunlan fuchunlan deleted the edit-app-temp branch June 28, 2021 02:33
@fuchunlan
Copy link
Contributor Author

/cherrypick release-3.1

@ks-ci-bot
Copy link
Collaborator

@fuchunlan: new pull request created: #2044

In response to this:

/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants