Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn.lock file isn't required by runtime #2024

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

RolandMa1986
Copy link
Member

Signed-off-by: Roland.Ma rolandma@yunify.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove yarn.lock file from the docker image.
There are some false positive CVE issues were reported by the scaner, which try to detect issues with the yarn.lock file. But some of those packages were not compiled into the release.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Roland.Ma <rolandma@yunify.com>
@ks-ci-bot ks-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2021
@RolandMa1986
Copy link
Member Author

RolandMa1986 commented Jun 25, 2021

/assign @harrisonliu5

@RolandMa1986
Copy link
Member Author

/cherrypick release-3.1

@ks-ci-bot
Copy link
Collaborator

@RolandMa1986: once the present PR merges, I will cherry-pick it on top of release-3.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, RolandMa1986

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@ks-ci-bot ks-ci-bot merged commit 77a70d1 into kubesphere:master Jun 25, 2021
@ks-ci-bot
Copy link
Collaborator

@RolandMa1986: new pull request created: #2026

In response to this:

/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants