Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add close button in create app template modal #2063

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

harrisonliu5
Copy link
Collaborator

Signed-off-by: harrisonliu5 harrisonliu_5@163.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2040

Special notes for reviewers:

Additional documentation, usage docs, etc.:


/assign @xuliwenwenwen

Signed-off-by: harrisonliu5 <harrisonliu_5@163.com>
@ks-ci-bot ks-ci-bot added dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2021
@harrisonliu5
Copy link
Collaborator Author

image

@fuchunlan
Copy link
Contributor

/lgtm

@ks-ci-bot
Copy link
Collaborator

@fuchunlan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Collaborator Author

/lgtm
/approve

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harrisonliu5
Copy link
Collaborator Author

/cherrypick release-3.1

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liuboaibc
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@ks-ci-bot ks-ci-bot merged commit dcd5c69 into kubesphere:master Jun 30, 2021
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2070

In response to this:

/cherrypick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5 harrisonliu5 deleted the fix/opDeployModal branch July 2, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants