New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Can't update volume for deloyment #2656
Conversation
e898e7c
to
d2e2b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
d2e2b2a
to
dc6f933
Compare
/assign @xuliwenwenwen |
/lgtm |
LGTM label has been added. Git tree hash: 0ed179a01b769bd7a3bbefbbcbedb27cd989b391
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5, weili520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-3.2 |
@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@harrisonliu5: new pull request created: #2663 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: TheYoungManLi cjl@kubesphere.io
What type of PR is this?
/kind bug
What this PR does / why we need it:
At before, we can't switch the type of mounted volume for deolyment, because the update volume didn't be removed from the deloyment spec.
Which issue(s) this PR fixes:
Fixes ##2467,##2505,##2345
Special notes for reviewers:
2021-11-24.14.16.30.mov
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: