Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can't update volume for deloyment #2656

Merged
merged 1 commit into from Nov 24, 2021

Conversation

weili520
Copy link
Collaborator

@weili520 weili520 commented Nov 24, 2021

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

At before, we can't switch the type of mounted volume for deolyment, because the update volume didn't be removed from the deloyment spec.

Which issue(s) this PR fixes:

Fixes ##2467,##2505,##2345

Special notes for reviewers:

2021-11-24.14.16.30.mov

Does this PR introduced a user-facing change?

Update volume info for deolyment failed.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2021
Copy link
Collaborator Author

@weili520 weili520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@harrisonliu5
Copy link
Collaborator

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0ed179a01b769bd7a3bbefbbcbedb27cd989b391

@harrisonliu5
Copy link
Collaborator

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@harrisonliu5
Copy link
Collaborator

/cherrypick release-3.2

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot merged commit 6eedc6f into kubesphere:master Nov 24, 2021
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2663

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520 weili520 deleted the container_volume_switch branch December 2, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants