Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In the composed app's details page, users cannot customize the time interval for the traffic monitoring #2916

Merged
merged 1 commit into from Jan 19, 2022

Conversation

weili520
Copy link
Collaborator

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##4491

Special notes for reviewers:

Add time controller component

截屏2022-01-17 17 03 48

2022-01-17.17.22.58.mov

Does this PR introduced a user-facing change?

In the composed app's details page, users cannot customize the time interval for the traffic monitoring.

@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2022
…ime interval for the traffic monitoring

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@weili520
Copy link
Collaborator Author

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 261139ba49f59d968c8ef6850ae3cb1ee4ebffe5

@harrisonliu5
Copy link
Collaborator

/cc @kubesphere/sig-testing

@harrisonliu5
Copy link
Collaborator

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@ks-ci-bot ks-ci-bot merged commit 35228c4 into kubesphere:master Jan 19, 2022
@weili520 weili520 deleted the time_control branch April 22, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants