Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the httpCookie is emtpy when sending request to update traffic p… #3831

Merged
merged 1 commit into from Oct 14, 2022

Conversation

mujinhuakai
Copy link
Contributor

@mujinhuakai mujinhuakai commented Oct 14, 2022

…olicy in traffic monitor page

What type of PR is this?

/kind bug

What this PR does / why we need it:

the httpCookie is emtpy when sending request to update traffic policy in traffic monitor page of app

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

/assign @zheng1

Does this PR introduced a user-facing change?

fixed the bug  when update traffic policy and load balance algorithm is based on http cookie

Additional documentation, usage docs, etc.:


@ks-ci-bot
Copy link
Collaborator

Hi @mujinhuakai. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2022
…olicy in traffic monitor page

Signed-off-by: liyanfang <liyanfang@cmss.chinamobile.com>
@harrisonliu5
Copy link
Collaborator

Thanks for your contributions.

@harrisonliu5
Copy link
Collaborator

You should input the release note in the PR information, Thanks.

@harrisonliu5
Copy link
Collaborator

/ok-to-test

@harrisonliu5
Copy link
Collaborator

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2bc6a5c596a2f812ff8779719f7c5b39b81a466b

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, mujinhuakai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@ks-ci-bot ks-ci-bot merged commit 3f3cc60 into kubesphere:master Oct 14, 2022
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3836

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants