Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Updating crd resource on ks-console page loses status information #3866

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

yzxiu
Copy link
Contributor

@yzxiu yzxiu commented Oct 22, 2022

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

Updating crd resource on ks-console page loses status information.
When the user modifies the crd through ks-console, it may cause some unexpected problems.

Which issue(s) this PR fixes:

Fixes #3865

Does this PR introduced a user-facing change?

When editing the crd resource through ks-console, the original status information will be loaded

Before and after the update

before: does not contain status information
image

after: contain status information
image

@ks-ci-bot
Copy link
Collaborator

Hi @yzxiu. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yzxiu
Copy link
Contributor Author

yzxiu commented Oct 25, 2022

/cc @harrisonliu5 @patrickluoyu

@harrisonliu5
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 88d5420ad7d1a6d605061087d4fb0d9d42f6049d

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, yzxiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@harrisonliu5
Copy link
Collaborator

Thank you for your contribution

@ks-ci-bot ks-ci-bot merged commit 46eecf6 into kubesphere:master Oct 18, 2023
3 checks passed
@yzxiu
Copy link
Contributor Author

yzxiu commented Oct 18, 2023

Thank you for your contribution

Thank you for your review, but this review made me wait for a whole year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating crd resource on ks-console page loses status information
4 participants