Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the CPU value of the container details that is displayed incorrectly because it has units. #3887

Merged

Conversation

harrisonliu5
Copy link
Collaborator

@harrisonliu5 harrisonliu5 commented Oct 25, 2022

Signed-off-by: harrisonliu5 harrisonliu@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##3890

Special notes for reviewers:

Before
image

After
image

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


…ncorrectly because it has units.

Signed-off-by: harrisonliu5 <harrisonliu@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Oct 25, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2022
@harrisonliu5
Copy link
Collaborator Author

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Collaborator Author

/assign @weili520

@weili520
Copy link
Collaborator

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 43801da79c2e0d429d14162d1e68b5a79e07b4f3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3888

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants