add tekton chart for installation

[wujiahao15]

resolves #62

Description:

• Add tekton pipeline chart into ks-devops for installation of tekton.
• We can use make install-chart in command line to install Jenkins, s2i and tekton-pipeline.
• After successfully installing the chart, the tekton components are deployed in the namespace called tekton-pipelines.

[codecov-commenter]

Codecov Report

Merging #100 (6a21e56) into master (bdd31ea) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #100   +/-   ##
======================================
  Coverage    5.34%   5.34%           
======================================
  Files          74      74           
  Lines       21072   21072           
======================================
  Hits         1126    1126           
  Misses      19873   19873           
  Partials       73      73           

Flag	Coverage Δ
unittests	5.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7714e9c...6a21e56. Read the comment docs.

[LinuxSuRen]

Thanks for your contribution. But IMO, we don't have a good reason to maintain the Tekton helm chart. So, it's not a good idea to commit the source files of it into this repository. I have two suggestions here:

• commit and commit a specific release helm chart of Tekton
  • it should be a file likes xxx.tgz
• create a PR against the branch tekton-support
  • we can merge the branch tekton-support into master when it's ready

[wujiahao15]

Thanks for your contribution. But IMO, we don't have a good reason to maintain the Tekton helm chart. So, it's not a good idea to commit the source files of it into this repository. I have two suggestions here:

• commit and commit a specific release helm chart of Tekton

  • it should be a file likes xxx.tgz

• create a PR against the branch tekton-support

  • we can merge the branch tekton-support into master when it's ready

Okay, Master.

[JohnNiang]

Thanks for your contribution. But I have a question for you: what should we do if we want to install ks-devops without tekton?

[wujiahao15]

Thanks for your contribution. But I have a question for you: what should we do if we want to install ks-devops without tekton?

How about adding condition field in the parent Chart.yaml to controll dependecies and adding charts.xxx.enabled in values.yaml?
e.g.

# Chart.yaml
...
dependencies:
  - name: jenkins
    version: 0.19.0
    condition: charts.jenkins.enabled
  - name: s2i
    version: 1.16.0
    condition: charts.s2i.enabled
  - name: tekton-pipeline
    version: 0.25.0
    condition: charts.tekton.enabled
...

# values.yaml
...
charts:
  jenkins:
    enabled: true
  s2i:
    enabled: true
  tekton:
    enabled: false
...

In this case, tekton is not installed by default. If we want to install tekton altogether, we can overwrite the value charts.tekton.enabled as true before installation.

i.e we could provide an alternative command in README.md, just like changing the container registry from gcr.io to docker.io.

e.g. adding the below message to the section of Install it as a Helm Chart in README.md

- Because tekton is not installed by default, if you want to install it, you can exec `helm install ks-devops chart/ks-devops --set charts.tekton.enabled=true`

[JohnNiang]

@flamywhale Thanks for your patient explanation. That makes sense to me.

[wujiahao15]

Thanks for your contribution. But IMO, we don't have a good reason to maintain the Tekton helm chart. So, it's not a good idea to commit the source files of it into this repository. I have two suggestions here:

• commit and commit a specific release helm chart of Tekton

  • it should be a file likes xxx.tgz

• create a PR against the branch tekton-support

  • we can merge the branch tekton-support into master when it's ready

I am little confused about the second suggestion in which I am supposed to create a PR against the branch tekton-support.
Do I need to close this PR and create a new one for the branch tekton-support?

[JohnNiang]

hi @flamywhale , you can edit anything of this PR directly.

[LinuxSuRen]

Everything is perfect. But it would be great if you can add a description about how (or where) do you get the chart zip file. For example, add a readme file under the directory: charts/ks-devops/charts/

[wujiahao15]

hi @flamywhale , you can edit anything of this PR directly.

Thanks!

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (tekton-support@7714e9c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9b4574a differs from pull request most recent head 993707e. Consider uploading reports for the commit 993707e to get more accurate results

@@               Coverage Diff                @@
##             tekton-support    #100   +/-   ##
================================================
  Coverage                  ?   5.34%           
================================================
  Files                     ?      74           
  Lines                     ?   21072           
  Branches                  ?       0           
================================================
  Hits                      ?    1126           
  Misses                    ?   19873           
  Partials                  ?      73           

Flag	Coverage Δ
unittests	5.34% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7714e9c...993707e. Read the comment docs.

[ks-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flamywhale
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JohnNiang]

/label tide/merge-method-squash

[LinuxSuRen]

/lgtm

[LinuxSuRen]

/label tide/merge-method-squash

It looks like the Prow has same problems.

[JohnNiang]

/label tide/merge-method-squash

[JohnNiang]

/lgtm

[ks-ci-bot]

@JohnNiang: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.