Fix that the controller did not use creator's token to trigger a Jenkins job

[JohnNiang]

What dose this PR?

1. Add devops.kubesphere.io/creator into annotations of PipelineRun
2. Trigger PipelineRun with specific token which is issued by devops.kubesphere.io/creator

Why do we need it?

At present, if we trigger a Pipeline using non-admin account, we will get message Started by admin always.

Steps to test

Docker images for test:

johnniang/devops-apiserver:dev-v3.2.1-rc.1-2debd81
johnniang/devops-controller:dev-v3.2.1-rc.1-2debd81

1. Create a Workspace, DevOps Project, Pipeline using admin account
2. Create another account tester and invite him/her into that Workspace and DevOps Project
3. Trigger that Pipeline using tester account
4. See the Last Message column

/kind bug
/milestone v3.2
/cc @kubesphere/sig-devops

[ks-ci-bot]

@JohnNiang: You must be a member of the kubesphere/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

What dose this PR?

1. Add devops.kubesphere.io/creator into annotations of PipelineRun
2. Trigger PipelineRun with specific token which is issued by devops.kubesphere.io/creator

Why do we need it?

At present, if we trigger a Pipeline using non-admin account, we will get message Started by admin always.

Steps to test

Docker images for test:

johnniang/devops-controller:dev-v3.2.1-rc.1-4deb5d9
johnniang/devops-apiserver:dev-v3.2.1-rc.1-4deb5d9

1. Create a Workspace, DevOps Project, Pipeline using admin account
2. Create another account tester and invite him/her into that Workspace and DevOps Project
3. Trigger that Pipeline using tester account
4. See the Last Message column

/kind bug
/milestone v3.2
/cc @kubesphere/sig-devops

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #384 (2debd81) into master (ba24eff) will increase coverage by 0.05%.
The diff coverage is 36.00%.

@@            Coverage Diff            @@
##           master    #384      +/-   ##
=========================================
+ Coverage    7.72%   7.78%   +0.05%     
=========================================
  Files          96      96              
  Lines       21582   21605      +23     
=========================================
+ Hits         1668    1682      +14     
- Misses      19791   19799       +8     
- Partials      123     124       +1     

Flag	Coverage Δ
unittests	7.78% <36.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/tools/jwt/app/jwt_root.go	100.00% <ø> (ø)
pkg/api/devops/v1alpha3/groupversion_info.go	0.00% <ø> (ø)
pkg/jwt/token/jwt.go	54.54% <ø> (ø)
pkg/kapis/devops/v1alpha3/pipelinerun/handler.go	0.00% <0.00%> (ø)
...lers/jenkins/pipelinerun/pipelinerun_controller.go	16.47% <50.00%> (+4.13%)	⬆️
controllers/s2irun/s2irun_controller.go	33.57% <0.00%> (-3.65%)	⬇️
...rs/devopscredential/devopscredential_controller.go	36.48% <0.00%> (+3.37%)	⬆️
controllers/pipeline/pipeline_controller.go	41.91% <0.00%> (+3.67%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba24eff...2debd81. Read the comment docs.

[LinuxSuRen]

/cherrypick release-3.2

[ks-ci-bot]

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JohnNiang]

/label tide/merge-method-squash

[JohnNiang]

/retest Test

[ks-ci-bot]

@JohnNiang: No presubmit jobs available for kubesphere/ks-devops@master

In response to this:

/retest Test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JohnNiang]

/test ?

[ks-ci-bot]

@JohnNiang: No presubmit jobs available for kubesphere/ks-devops@master

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JohnNiang]

I've run make test in my local environment many times, and it always passes.

I'm going to re-run the workflow by closing and reopening this PR.

[JohnNiang]

/ping @kubesphere/sig-devops

[LinuxSuRen]

hi @JohnNiang , The real problem is that the controller didn't use the correct user to trigger a Jenkins job.

showing wrong message "started by admin" while triggering by non-admin user describes a UI issue.

So, I suggest you provide a more accurate title.

[JohnNiang]

hi @JohnNiang , The real problem is that the controller didn't use the correct user to trigger a Jenkins job.

showing wrong message "started by admin" while triggering by non-admin user describes a UI issue.

So, I suggest you provide a more accurate title.

Thanks for your suggestion!

/retitle Enable the controller to trigger a Jenkins job with the token of the creator

[JohnNiang]

/retitle Fix that the controller did not use creator's token to trigger a Jenkins job

[LinuxSuRen]

I have tested it manually. It works well.
/lgtm
/approve

[ks-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LinuxSuRen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ks-ci-bot]

@LinuxSuRen: new pull request created: #388

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.