Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the ks-install label in logs command in README.md #1913

Merged
merged 1 commit into from
May 5, 2022

Conversation

KR411-prog
Copy link

kubectl logs -n kubesphere-system $(kubectl get pod -n kubesphere-system -l app=ks-install -o jsonpath='{.items[0].metadata.name}') -f

The label is fixed as app=ks-install

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2022
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @KR411-prog , thanks for the fix. It's great!
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5c7d0f630e570c0d555b9cc964246d942744221a

@LinuxSuRen
Copy link
Member

/cc @kubesphere/sig-installation

@ks-ci-bot ks-ci-bot requested a review from a team April 8, 2022 01:21
@pixiake
Copy link
Collaborator

pixiake commented Apr 8, 2022

I found that the labels of related resources in the master branch have been modified like app: ks-installer . So I think this may not need to be modified in master branch.

@pixiake
Copy link
Collaborator

pixiake commented May 5, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KR411-prog, LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@ks-ci-bot ks-ci-bot merged commit b93d3b1 into kubesphere:master May 5, 2022
@pixiake
Copy link
Collaborator

pixiake commented May 5, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1975

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants