Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image list of the Argo CD #1939

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Add image list of the Argo CD #1939

merged 1 commit into from
Apr 15, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 12, 2022 •
edited

fix #1930

/area devops

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2022
@LinuxSuRen
Copy link
Member Author

/area devops

@pixiake
Copy link
Collaborator

pixiake commented Apr 13, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
pixiake
pixiake reviewed Apr 13, 2022
View reviewed changes
roles/download/defaults/main.yml
argocd_applicationset_tag: v0.4.1
argocd_dex_repo: "{{ base_repo | default('ghcr.io/') }}{{ namespace_override | default('dexidp') }}/dex"
argocd_dex_tag: v2.30.2
argocd_redis_repo: "{{ base_repo }}{{ namespace_override }}/redis"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can argocd use the same redis as kubesphere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. I guess more tests are needed if we let them use the same image version.

@pixiake
Copy link
Collaborator

pixiake commented Apr 15, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: b4f38cfbf878527a0d9dd54bff1beaa96b2695a7

@ks-ci-bot ks-ci-bot merged commit 60e11c2 into kubesphere:master Apr 15, 2022
@pixiake
Copy link
Collaborator

pixiake commented Apr 15, 2022

/cherrypick release-3.3

@ks-ci-bot ks-ci-bot mentioned this pull request Apr 15, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1944

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the argocd-image-list branch April 15, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake pixiake left review comments

Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put all the images of Argo CD into the image list
3 participants
@LinuxSuRen @pixiake @ks-ci-bot