Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline image items for golang 17 and 18 #1940

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Add offline image items for golang 17 and 18 #1940

merged 2 commits into from
Apr 15, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 12, 2022 •
edited
Loading

The upstream PR is kubesphere/devops-agent#70

see also #1938

@LinuxSuRen
Copy link
Member Author

LinuxSuRen commented Apr 12, 2022 •
edited
Loading

/hold until we have a release
/area devops

@ks-ci-bot ks-ci-bot added do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2022
@LinuxSuRen
Copy link
Member Author

/area devops

@LinuxSuRen
Copy link
Member Author

/unhold
/cc @kubesphere/sig-installation

@ks-ci-bot ks-ci-bot requested a review from a team April 15, 2022 03:05
@pixiake
Copy link
Collaborator

pixiake commented Apr 15, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Apr 15, 2022

/approve
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2576b9b98c5dd22eee579782c543eafbf9756340

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2022
@ks-ci-bot ks-ci-bot merged commit 58c0f26 into kubesphere:master Apr 15, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Apr 15, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1945

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the go18 branch April 15, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LinuxSuRen @pixiake @ks-ci-bot