Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing permission of ks-devops #1948

Merged

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 19, 2022

fix kubesphere/ks-devops#430
fix kubesphere/console#3146
fix kubesphere/ks-devops#473

/area devops

hi @wansir , I'm thinking if you could help me to review this issue.

@LinuxSuRen
Copy link
Member Author

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2022
@LinuxSuRen
Copy link
Member Author

/cc @kubesphere/sig-installation

@ks-ci-bot ks-ci-bot requested a review from a team April 20, 2022 05:35
@LinuxSuRen LinuxSuRen closed this Apr 24, 2022
@LinuxSuRen LinuxSuRen reopened this Apr 24, 2022
@pixiake
Copy link
Collaborator

pixiake commented Apr 25, 2022

/lgtm

1 similar comment
@pixiake
Copy link
Collaborator

pixiake commented Apr 25, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9321d9ece799d212e77e7919527846f6f98dc924

@pixiake
Copy link
Collaborator

pixiake commented Apr 25, 2022

/approve

1 similar comment
@pixiake
Copy link
Collaborator

pixiake commented Apr 25, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@ks-ci-bot ks-ci-bot merged commit b23128e into kubesphere:master Apr 25, 2022
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: new pull request created: #1955

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the fix-missing-permissions-devops branch April 26, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants