reuse values when upgrading argo-cd #1961
Conversation
ks-ci-bot
added
the
size/XS
|
/cc @kubesphere/sig-devops |
There was a problem hiding this comment.
hi @daixijun , thanks for your time. Please see the comment and help us to understand the changes.
/area devops
| @@ -177,7 +177,7 @@ | |||
| executable: /bin/bash | |||
| shell: | | |||
| {{ bin_dir }}/helm upgrade --install devops {{ kubesphere_dir }}/ks-devops/charts/argo-cd-4.4.0.tgz \ | |||
| -n argocd --create-namespace | |||
| -n argocd --create-namespace --reuse-values | |||
There was a problem hiding this comment.
I'm wondering if you mind providing some background about why we should use the flag --reuse-values.
There was a problem hiding this comment.
For example, add the private GitLab server key to ssh_known_hosts, These configurations are reset when the ks-installer restarts or is upgraded
There was a problem hiding this comment.
But I still feel confused, why cannot use the value from the newer version?
There was a problem hiding this comment.
But I still feel confused, why cannot use the value from the newer version?
英语不太好，我就用中文说吧
也不是说不可能使用新版本的值， 而是默认的 values.yaml 里面的值会覆盖掉自定的值。
就以我上面举例来说， 添加私有GIT仓库的时候是需要录入服务器的 ssh keys, 实际他是存储在 argocd/argocd-ssh-known-hosts-cm 这个 configmap中， 如果不复用参数在升级的时候就会被覆写为默认值 ， 这时候 argocd 里面的仓库就会失联
|
LGTM label has been added. Git tree hash: b66e0615c0e7cd6f36bc49135521c4a6ca768171
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daixijun, LinuxSuRen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
|
/cherrypick release-3.3 |
|
@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@LinuxSuRen: new pull request created: #1972 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.