Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid install s2i templates via the helm chart #1986

Merged
merged 1 commit into from
May 12, 2022
Merged

Avoid install s2i templates via the helm chart #1986

merged 1 commit into from
May 12, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented May 12, 2022 •
edited

This is missing part of #1984

/area devops

@LinuxSuRen
Avoid install s2i templates via the helm chart
4dba062 
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2022
@LinuxSuRen
Copy link
Member Author

hi @pixiake , please feel free to help review this PR as well.
/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

hi @pixiake , please feel free to help review this PR as well.
/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen
Copy link
Member Author

/area devops

@pixiake
Copy link
Collaborator

pixiake commented May 12, 2022

/approve
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5df327d636b3f997e0b94b8eeac3eb3b1bb5bef2

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 2b91c9b into kubesphere:master May 12, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request May 12, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: new pull request created: #1990

In response to this:

hi @pixiake , please feel free to help review this PR as well.
/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the fix-s2i-templates branch May 12, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LinuxSuRen @ks-ci-bot @pixiake