Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore some rule fixes #1993

Merged
merged 1 commit into from
May 18, 2022
Merged

restore some rule fixes #1993

merged 1 commit into from
May 18, 2022

Conversation

junotx
Copy link
Contributor

@junotx junotx commented May 18, 2022

This synchronizes update in https://github.com/kubesphere/ks-prometheus/pull/6 to restore some rule fixes.

/cc @benjaminhuo

Signed-off-by: junot <junotxiang@kubesphere.io>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2022
@benjaminhuo
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: bd2de346c64bb0a6108e1eb780206fddd29537d4

@benjaminhuo
Copy link
Member

@junotx should this fix be included in 3.3?

@benjaminhuo benjaminhuo requested a review from pixiake May 18, 2022 07:50
@junotx
Copy link
Contributor Author

junotx commented May 18, 2022

@junotx should this fix be included in 3.3?

Yes, should cherry-pick to release-3.3 branch

@pixiake
Copy link
Collaborator

pixiake commented May 18, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented May 18, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@ks-ci-bot ks-ci-bot merged commit 7bcde55 into kubesphere:master May 18, 2022
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1994

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junotx junotx deleted the rule-fixes branch July 25, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants