Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ks-istio-monitoring to ensure monitoring files are installed #2021

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

frezes
Copy link
Member

@frezes frezes commented Jun 20, 2022

Fixes: #2020

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2022
@frezes
Copy link
Member Author

frezes commented Jun 20, 2022

/cc @benjaminhuo @junotx @pixiake

Signed-off-by: frezes <zhangjunhao@kubesphere.io>
@frezes frezes force-pushed the feat/adjust_ks-istio-monitoring branch from 43454d0 to f4c6c53 Compare June 20, 2022 08:38
@pixiake
Copy link
Collaborator

pixiake commented Jun 21, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Jun 21, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: aaf976518caa229dcdc2ce451832fe0d3223633f

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frezes, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@ks-ci-bot ks-ci-bot merged commit 260d616 into kubesphere:master Jun 21, 2022
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2022

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing monitoring files when kk first deployed ks-istio.
3 participants