Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix applying prometheus crd metadata annotations tool long #2055

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Jul 27, 2022

fix applying prometheus crd metadata annotations tool long in lower k8s version

fixes:
kubesphere/kubesphere#5012

the Prometheus crd update is synced from https://github.com/kubesphere/ks-prometheus/pull/7

Signed-off-by: junot <junotxiang@kubesphere.io>
@junotx
Copy link
Contributor Author

junotx commented Jul 27, 2022

/cc @benjaminhuo

@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 27, 2022
@benjaminhuo
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 91cba3e3afddd2f121dd2c6ca8f6b4b45d6adc70

@benjaminhuo
Copy link
Member

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@ks-ci-bot ks-ci-bot merged commit 3d53a20 into kubesphere:master Jul 27, 2022
@junotx
Copy link
Contributor Author

junotx commented Jul 27, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@junotx: new pull request created: #2056

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junotx junotx deleted the fix-5012 branch July 29, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants