Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of wrong display name at frontend #2080

Merged
merged 5 commits into from
Aug 24, 2022

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Aug 19, 2022

This PR is used for fixing bug of kubesphere/kubesphere#5150 kubesphere/kubesphere#5149
Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2022
@zhou1203
Copy link
Member Author

/assign @wansir
/assign @pixiake

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2022
@wansir
Copy link
Member

wansir commented Aug 22, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c9a71f18fe1956622b8e5741dcd0374c7696a110

@zhou1203 zhou1203 changed the title add annotation alias-name Update labels of roletemplates iam.kubesphere.io/role-template to false Aug 22, 2022
Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@zhou1203 zhou1203 changed the title Update labels of roletemplates iam.kubesphere.io/role-template to false Fix the bug of wrong display name at frontend Aug 23, 2022
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@zhou1203
Copy link
Member Author

/cc @pixiake

@ks-ci-bot ks-ci-bot requested a review from pixiake August 23, 2022 06:22
@pixiake
Copy link
Collaborator

pixiake commented Aug 24, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Aug 24, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, wansir, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@pixiake
Copy link
Collaborator

pixiake commented Aug 24, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 8f06118733ab1fcf3db8586e7b4cbe50735ac731

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2086

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants